Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following modifications are required to support the ZSA circuit changes:
mul_sign
. The implementation is based on theq_mul_fixed_short
gate.CommitDomain::new_with_personalization
to initialize theCommitDomain
from two different personalizations. This is required to be able to use an identicalR
for ZEC and ZSA note commitments but a differentQ
.HashDomain
in aCommitDomain
publicly to enable the usage of Sinsemilla hash function from aCommitDomain
.commit_from_hash_point
to evaluate a Sinsemilla commit from a hash point.hash
andblind
independently.MUX(choice, left, right) = if {choice} right else left
Point::new_from_constant
to create a Point from a constant.hash_to_point_with_private_init
to evaluate a Sinsemilla hash from a private initial point (instead of a public initial point)